jaspermayone / website

Personal Website for @jaspermayone.
https://jaspermayone.com
3 stars 2 forks source link

[BUG] Photo Metadata is broken after move to S3 #49

Closed jaspermayone closed 1 month ago

VividhPandey003 commented 2 months ago

Hey @jaspermayone can you tell me more about this issue, I would like to work on it

jaspermayone commented 2 months ago

Hi @VividhPandey003,

In commit https://github.com/jaspermayone/website/commit/8c53a88debedaf86622cc8de4f9b5927ba23a988

I moved to S3 for image storing as part of #50.

Now, all the metadata for the images shows as undefined, even though I know there's metadata on the image.

jaspermayone commented 2 months ago

Does that make sense?

ofluffydev commented 2 months ago

Why using S3?

ofluffydev commented 2 months ago

And just to confirm this is causing #50 ?

jaspermayone commented 2 months ago

No, I think 50 is related though.

jaspermayone commented 2 months ago

S3 because the files are too large to host on vercel as part of the site, and s3 is the standard for these types of things

Lokendra-sinh commented 2 months ago

@jaspermayone there's no issue with S3. S3 will store whatever metadata we pass into.

This is what I've observed: -> Downloaded an image directly from S3. -> put it into exif processing and realised, there wasn't enough metadata you'd typically see in the original picture. -> It tells that the image was processed somewhere in between and that explains the issue with metadata. Because the metadata is inconsistent with images...I believe this might be the issue.

image
jaspermayone commented 1 month ago

Ahhhh so this is tied with #50

jaspermayone commented 1 month ago

Bizzare

jaspermayone commented 1 month ago

I want to go back to local photos but Vercel is being a pain

ofluffydev commented 1 month ago

Also the metadata is showing in the console but not the website.

aramshiva commented 1 month ago

Doesn’t remove metadata? It’s optimizing the imageOn Sep 27, 2024, at 7:22 AM, Kaden Frisk @.***> wrote: Also the metadata is showing in the console but not the website.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

jaspermayone commented 1 month ago

I don't think so? I am displaying the metadata as an overlay so the tag shouldn’t matter