Implement Back Button on Photos Page

jaspermayone / website

Personal Website for @jaspermayone.

https://jaspermayone.com

2 stars 2 forks source link

Implement Back Button on Photos Page #52

Closed aliraza556 closed 4 days ago

aliraza556 commented 1 week ago

Problem:

No back button on photos page

Issue ticket number and link:

Ticket Number: [ 48 ]
Link: [ https://github.com/jaspermayone/website/issues/48 ]

closes #48

Evidence:

Acceptance Criteria:

[x] Add Back Button on Photos Page

vercel[bot] commented 1 week ago

@aliraza556 is attempting to deploy a commit to the Jasper Mayone Team on Vercel.

A member of the Team first needs to authorize it.

aliraza556 commented 1 week ago

Hi @jaspermayone, Please review this PR.

jaspermayone commented 1 week ago

Hi @aliraza556, there's already code for a back button implemented, it just isn't working and needs to be fixed.

aliraza556 commented 1 week ago

Hi @aliraza556, there's already code for a back button implemented, it just isn't working and needs to be fixed.

@jaspermayone, Ok.

aliraza556 commented 1 week ago

Hi @jaspermayone, could you please tell me where the back button is implemented?

jaspermayone commented 1 week ago

@aliraza556 it's in the code, just not implemented in the element handler properly.

jaspermayone commented 4 days ago

Following back up @aliraza556...

aliraza556 commented 4 days ago

@jaspermayone, I couldn't find the BackButton implementation. Please guide me?

aliraza556 commented 4 days ago

@jaspermayone, I reviewed the entire project code, and I only found the Button code, but I couldn't find any BackButton code.

https://github.com/jaspermayone/website/blob/main/src/components/ui/button.tsx

GitHub
website/src/components/ui/button.tsx at main · jaspermayone/website
Personal Website for @jaspermayone. Contribute to jaspermayone/website development by creating an account on GitHub.

jaspermayone commented 4 days ago

@aliraza556 check out the code here, I do something very similar

https://github.com/jaspermayone/website/blob/b48a1e40a5784dc0357d7370515b991d477fed15/src/components/ui/friends.tsx#L42-L65

aliraza556 commented 4 days ago

Hi @jaspermayone, Please review this PR:

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
website	❌ Failed (Inspect)			Oct 3, 2024 2:15pm

aliraza556 commented 2 days ago

Hi @jaspermayone, could you please guide me on how to claim the bounty I was rewarded? Thanks in advance!