search

jaspervdj / digestive-functors

A general way to consume input using applicative functors
149 stars 71 forks source link

error while building on ghc 8.4.2 #151

Open DanielCollins opened 6 years ago

DanielCollins commented 6 years ago

https://gist.githubusercontent.com/DanielCollins/7ec09db73295cd4a24aa9a6ab07040b9/raw/e8fa80ade7f359e1fd029ec13de4be68930bb934/gistfile1.txt

works if i switch to 8.2.2.

jonpetterbergman commented 6 years ago

I have a branch which builds with GHC 8.4.3:

https://github.com/jonpetterbergman/digestive-functors/tree/ghc-8.4.3

The issue is that Semigroup became a superclass of Monoid in base 4.11.0.0.

Data.Semigroup was first included in base 4.9, so I bumped the lower bound on base.

In order to support older versions of base you could use an alternative dependency on the semigroup package for base versions <4.9.

saurabhnanda commented 6 years ago

Bumped into this issue while upgrading our project to latest stack LTS. Has this branch already been merged into master? Is master stable enough to use directly as a dependency from github?

jonpetterbergman commented 6 years ago

It has not been merged. There are also two pull requests regarding the same issue.

saurabhnanda commented 6 years ago

I have raised a PR that builds against Stack LTS 12.1 Please have a look.

jaspervdj commented 6 years ago

I merged the PR and will do releases/fixes on monday. Apologies for the delay.