jaspervdj / hakyll

A static website compiler library in Haskell
jaspervdj.be/hakyll
Other
2.69k stars 411 forks source link

Allow filepath-1.5 #1019

Closed LaurentRDC closed 5 months ago

LaurentRDC commented 7 months ago

This PR simply loosens the upper bound on filepath to allow version 1.5

Minoru commented 7 months ago

I'd like to wait for hashable to start supporting it too, because currently I can't run tests:

$ for action in build test ; do cabal $action --enable-tests --constrain 'filepath == 1.5.2.0' --allow-newer=hashable:filepath || break ; done

...

Failed to build hashable-1.4.3.0.
Build log (
/home/minoru/.cabal/logs/ghc-9.8.2/hashable-1.4.3.0-a76b9279436049ed5837719de4f0a953feb741885938b2eb4f1beeddef8bc291.log
):
Configuring library for hashable-1.4.3.0..
Preprocessing library for hashable-1.4.3.0..
Building library for hashable-1.4.3.0..
[1 of 7] Compiling Data.Hashable.Imports ( src/Data/Hashable/Imports.hs, dist/build/Data/Hashable/Imports.o, dist/build/Data/Hashable/Imports.dyn_o )
[2 of 7] Compiling Data.Hashable.LowLevel ( src/Data/Hashable/LowLevel.hs, dist/build/Data/Hashable/LowLevel.o, dist/build/Data/Hashable/LowLevel.dyn_o )
[3 of 7] Compiling Data.Hashable.Class ( src/Data/Hashable/Class.hs, dist/build/Data/Hashable/Class.o, dist/build/Data/Hashable/Class.dyn_o )

src/Data/Hashable/Class.hs:167:1: error: [GHC-87110]
    Could not load module ‘System.OsString.Internal.Types’.
    It is a member of the hidden package ‘os-string-2.0.2’.
    Perhaps you need to add ‘os-string’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘filepath-1.4.200.1’.
    Perhaps you need to add ‘filepath’ to the build-depends in your .cabal file.
    Use -v to see a list of the files searched for.
    |
167 | import System.OsString.Internal.Types (OsString (..), PosixString (..), WindowsString (..))
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: cabal: Failed to build hashable-1.4.3.0 (which is required by
test:hakyll-tests from hakyll-4.16.2.0 and exe:hakyll-init from
hakyll-4.16.2.0). See the build log above for details.
andreasabel commented 6 months ago

@Minoru : hashable-1.4.4 has been released.

Minoru commented 5 months ago

@andreasabel Thanks!

Tests run fine now, so merging. Thanks @LaurentRDC!

Minoru commented 5 months ago

Created 4.16.2.0@rev:6 on Hackage.