search

jaspervdj / hakyll

A static website compiler library in Haskell
jaspervdj.be/hakyll
Other
2.7k stars 409 forks source link

Test Failure in Hakyll.Core.UnixFilter.Tests #669

Open jhmcstanton opened 6 years ago

jhmcstanton commented 6 years ago

Locally the test Hackyll.Core.UnixFilter.Tests.unixFilterError fails when running stack test

  Hakyll.Core.UnixFilter.Tests
    unixFilter rev:        OK
    unixFilter false:      OK
    unixFilter error:      FAIL
      tests/Hakyll/Core/UnixFilter/Tests.hs:70:
      expected: True
       but got: False
jhmcstanton commented 6 years ago

Hm, just noticed that master is building just fine without this change: master build. Has this error been seen before?

jhmcstanton commented 6 years ago

FWIW, I also tried building master with cabal using the same process that master build used

$ cabal sandbox init
$ cabal install --only-dependencies --enable-tests --jobs=1 --flags="+buildWebsite
$ cabal test

and still have the same test failure

...
 Hakyll.Core.UnixFilter.Tests
    unixFilter rev:        OK
    unixFilter false:      OK
    unixFilter error:      FAIL
      tests/Hakyll/Core/UnixFilter/Tests.hs:70:
      expected: True
       but got: False
...
1 out of 133 tests failed (0.85s)
Test suite hakyll-tests: FAIL
Test suite logged to: dist/test/hakyll-4.12.4.0-hakyll-tests.log
0 of 1 test suites (0 of 1 test cases) passed.

This is with cabal 1.24.0.0 and GHC 8.0.1 (old, I know, generally using stack now though)

jhmcstanton commented 6 years ago

Latest change resolves this issue for myself and against Circle CI