search

jaspervdj / hakyll

A static website compiler library in Haskell
jaspervdj.be/hakyll
Other
2.7k stars 409 forks source link

Fix all GHC warnings #955

Closed Minoru closed 2 years ago

Minoru commented 2 years ago

This fixes warnings of all GHC versions we have in CI, and also adds -Werror to CI so we don't backslide on this.

Closes #939. I decided against dropping older GHC versions. Instead, I simply document the current state of things: Hakyll already fails to build with GHC 8.4 due to template-haskell requirement, so our CI will only test 8.6+. My goal for now is to keep each GHC version supported for as long as it's feasible, i.e. our dependencies support it and it doesn't create too much work for us to support it too.

Minoru commented 2 years ago

Windows build fails because of unlucky timing: hfsnotify 0.4.0.1 is currently broken on Windows. The fixes are already in master though (https://github.com/haskell-fswatch/hfsnotify/issues/107), so I'll wait for a new release and re-start the CI runs here.

Minoru commented 2 years ago

This finally passes CI! I'll wait a day or two, do a self-review, and merge. Reviews from others are welcome too!

Minoru commented 2 years ago

Well this looks good enough, even if I say so myself :) Let's merge it!