jaspreeth / ardupilot-mega

Automatically exported from code.google.com/p/ardupilot-mega
0 stars 0 forks source link

Stabilize should be throttle passthrough #353

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. set THROTTLE_MAX to 75 (default)
2. set stabilize mode
3.

What is the expected output? What do you see instead?
throttle should be output=rc input
instead we get output = max(rc input, max throttle)

line 279 of Attitude.pde function set_servos_4
g.channel_throttle.servo_out = constrain(g.channel_throttle.servo_out, 
g.throttle_min.get(), g.throttle_max.get());

What version of the product are you using? On what operating system?
2.11

Please provide any additional information below.
workaround is : set THROTTLE_MAX to 100
but it is confusing as I exepect stabilize to not interfere with throttle

Original issue reported on code.google.com by mbada...@gmail.com on 31 May 2011 at 9:43

GoogleCodeExporter commented 8 years ago
all apm modes (except manual) are constrained to max throttle.

But if your needing more throttle in stabilize mode, then indeed you should be 
upping the throttle_max values. as that is a good indication if it doesnt have 
enough power to climb or manuver. 

Your max value should allow the plane to climb to the next waypoint altitude, 
or to maintain a proper climbout during takeoff. 

fbw-a mode is also constrained to max throttle but with max pitch and max bank 
included.

I believe the default value is set a bit above mid range, for max power 
savings. But usually with sufficient power for the standard platform. 

I personally jack that up to 100 for performance vs power savings... as I will 
be utilizing auto-takeoff.

Cruise throttle and Cruise speed are also very handy to tweek to your platform.

I am going to close the issue, but feel free to reopen if this doesnt satisfy 
or you would like to request an enhancement or assistance in creating another 
mode.

Darren

Original comment by Draconis...@gmail.com on 1 Jun 2011 at 2:35

GoogleCodeExporter commented 8 years ago
The code states the following and I do believe that most users think stabilize 
does not touch throttle which is not true.
            case STABILIZE:
                nav_roll        = 0;
                nav_pitch       = 0;
                // throttle is passthrough
                break;
Whether we should have a big warning in the doc or change the default (you 
state that you change this value to 100 as well) as 75 is default. 
I consider this as a bug and not a new feature.

Original comment by mbada...@gmail.com on 1 Jun 2011 at 8:45