jassenm / android-todo

0 stars 0 forks source link

Project Feedback! #1

Open codepathreview opened 7 years ago

codepathreview commented 7 years ago

Hello Jassen, Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project-based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn the practical elements of Android development and best practices as quickly as possible. We also do a code review for each submitted project once the program begins.

The next step is to continue working on extensions to your todo app. With regards to extensions to implement, we are looking for developers with an interest in user experience and product development so be sure to focus on additional functional enhancements and/or improving the user interface of the app. You can re-submit on the application dashboard anytime and we'll take another look.

We'll be following up with you again shortly to outline the next steps in the admissions process.

codepathreview commented 7 years ago

Hi Jassen,

Thanks for completing the initial pre-work! Based on the high-volume of applications (500+) we've received, we strongly suggest that you continue extending your todo app with new functionality and/or improve the user interface. You can re-submit your app anytime with updates through the application dashboard after updating your README.md with latest features.

codepathreview commented 7 years ago

Hi Jassen, you've re-submitted your app, but haven't checked, what features you added this time.

Please update your README.MD. It will help us to be sure, that we haven't missed any new feature, that you have added.

nesquena commented 7 years ago

Hi Jassen,

Now that you've submitted an initial pre-work, the next step is to continue working on extensions to your todo app and to schedule a short 15-minute phone conversation with us here. Find a date that works for you and confirm a 15-minute slot. Let us know if none of those times work. You can read more about how to prepare for the phone conversation here.

Prior to our chat, can you take some time to research the most common Android Activity lifecycle methods as well as the ArrayAdapter pattern used when working with lists? We will be discussing these topics with you conceptually in the phone call. We encourage you to search our guides as well as any other sources you'd like.

Once you select a slot, you'll be sent a calendar invite with the phone number to call. Look forward to chatting soon!

codepathreview commented 7 years ago

Great to see you were able to augment your app with many extensions now. You can also improve you score by polishing UI, not only by adding features. As mentioned earlier, the extension tasks available on each project are often the most valuable learning since they dive deeper into common real-world Android use cases.

We'll be in touch with you again soon via email. Let us know if you have any questions about the project or anything in the meantime, you can always reach us at admissions@codepath.com.

jassenm commented 7 years ago

Thanks. I've just committed a new version which has the following changes:

Clean up the UI. Added swipe delete and confirmation dialog Added priority attribute Persisted date in SQLite. Moved hardcoded strings to @string values.

https://github.com/jassenm/android-todo