jast / gitinfo

Git info bot for #git on Freenode - REPOSITORY MOVED
https://notabug.org/jast/gitinfo
GNU General Public License v3.0
15 stars 3 forks source link

"join" plugin does not work. #10

Open EugeneKay opened 10 years ago

EugeneKay commented 10 years ago

The "join" plugin causes a crash when invoked as .join and/or generally does not work. Console log of crash:

$ ./gitinfo-irc.pl
[Mon Feb  3 19:00:58 2014] [INFO]    Control server started.
[Mon Feb  3 19:00:58 2014] [INFO]    Plugin 'join' loaded.
[Mon Feb  3 19:00:58 2014] [INFO]    Plugin 'text_trigger' loaded.
[Mon Feb  3 19:00:58 2014] [INFO]    IRC: connected to chat.freenode.net
Not an ARRAY reference at plugins/join.pm line 14.
$

Also mistakenly claims invalid channel name when invoked directly with .join #channel - suspect bad regex matching causing this one.

Running off the current HEAD + Pull Request #9 so this plugin will actually load.

jast commented 10 years ago

Sorry, join is one of the plugins I haven't really used myself for some reason. Does the updated version work for you?

EugeneKay commented 10 years ago

It does not complain as loudly, but the plugin does not work as intended. Interaction log follows:

<Eugene> .join
-CyanBot- Auto-joined configured channels: #cyanogenmod-dev, #cyanogenmod
<Eugene> .join #vlege
-CyanBot- You may not join me to channels that aren't configured. Sorry.

Channels list does include #vlege (bot was /kick'ed from it for test). But at least it doesn't crash anymore!

jast commented 10 years ago

No idea what's happening there. Once I get my computer moved to my new home (maybe next month?) I'll dig deeper...

jast commented 10 years ago

I just tested this in my production instance. WFM...

jast commented 10 years ago

Does this issue still exist for you? If so, please catch me on IRC some time so we can try and figure out what's going on.

EugeneKay commented 10 years ago

It is still broken, yes. I am running off abf5205, but nothing since then touches this plugin. Catch me this weekend whenever is convenient for you.