search

jasudev / AxisContribution

A library that expresses a github contribution calendar through an array of dates. Supports iOS and macOS.
MIT License
111 stars 24 forks source link

Bugfix: weekDay tooltip with considering user locale settings, start of dates as the key of dict etc. #13

Open Maples7 opened 5 months ago

Maples7 commented 5 months ago

this means to fix the bug https://github.com/jasudev/AxisContribution/issues/12 and #14.

Basically 4 issues:

  1. fix the weekDay tooltip considering user's locale settings
  2. sourceDatas should use the start of dates as the dictionary's keys
  3. don't show any grids after the toDate.
  4. reset the parameter type of sourceDatas back to [Date] for backward compatibility.
Maples7 commented 4 months ago

Kindly ping @jasudev for code review. Thx! :D