search

jaswdr / faker

:rocket: Ultimate fake data generator for Go with zero dependencies
https://pkg.go.dev/github.com/jaswdr/faker
MIT License
566 stars 59 forks source link

Update README.md: removes faker import confusion #124

Closed MaerF0x0 closed 2 years ago

MaerF0x0 commented 2 years ago

creating both a variable and import name faker is confusing and lead me wondering where the docs where for these functions like .Person()

Took some careful inspection to realize you're hiding the faker import with a faker variable.

Consider this change set to make it more legible and clear about what is going on.

Description

Replace this line with a short description of your changes

Are you trying to fix an existing issue?

Replace this line with a link to the issue you are trying to fix

Go Version

$ go version
# replace this line with the output

Go Tests

$ go test
# replace this line with the output
jaswdr commented 2 years ago

LGTM

jaswdr commented 2 years ago

Merged, @MaerF0x0 thank you for catching this 👍