jaswdr / faker

:rocket: Ultimate fake data generator for Go with zero dependencies
https://pkg.go.dev/github.com/jaswdr/faker
MIT License
549 stars 59 forks source link

Fix signature of UintBetween generator functions #131

Closed Kingmidas74 closed 1 year ago

Kingmidas74 commented 1 year ago

Signature of function Uint(8/16/32/64)Between is replaced from int params to uint params. Also for more idiomatic way that methods now calling to base UIntBetween instead of IntBetween.

Go Version

$ go version
go version go1.19.5 darwin/arm64

Go Tests

$ go test
2023/02/27 21:59:56 Error while requesting https://loremflickr.com/300/200 : request failed
2023/02/27 21:59:57 Error while creating a temp file: temp file creation failed
2023/02/27 21:59:58 Error while requesting https://thispersondoesnotexist.com/image : request failed
2023/02/27 21:59:58 Error while creating a temp file: temp file creation failed
PASS
ok      github.com/jaswdr/faker 5.998s
jaswdr commented 1 year ago

Thank you for the contribution. I saw some tests failing. due to network issue, I'll rerun them and enable the auto-merge.