search

jaswdr / faker

:rocket: Ultimate fake data generator for Go with zero dependencies
https://pkg.go.dev/github.com/jaswdr/faker
MIT License
566 stars 59 forks source link

Adding generator for https://thispersondoesnotexist.com/ #56

Closed FournyP closed 3 years ago

FournyP commented 3 years ago

Description

Adding ThisPersonDoesNotExist support in #50

Are you trying to fix an existing issue?

Adding new generator to create profil picture more realistics using the remote service https://thispersondoesnotexist.com/

Go Version

$ go version
go version go1.16.3 windows/amd64

Go Tests

$ go test -v
PASS
ok      github.com/jaswdr/faker 0.754s
jaswdr commented 3 years ago

I forget to mention in the previous PR, but I was checking your repo and saw the ProfilePicture generator, I've added it here, just changing the "Picture" to "Image" because we already mention the word "Image" in other files. I've also added it to the "person.go" file, so people can use the "faker.Person().Image()" method to generate a profile image.

In any case, thank you very much for the PR, I'll close it in favour of the changes I mentioned, feel free to make any other suggestion or sent new PR's.