jaswdr / faker

:rocket: Ultimate fake data generator for Go with zero dependencies
https://pkg.go.dev/github.com/jaswdr/faker
MIT License
549 stars 59 forks source link

Fixing #83 by handling invalid e-mail names #84

Closed jaswdr closed 2 years ago

jaswdr commented 2 years ago

Description

As reported in #83 some emails names were invalid due to the fact that some first names have ", like O"Connol. This change fixes that by only allowing valid characters and improve the detection by validating the email address in tests.

Are you trying to fix an existing issue?

Fixing #83

Go Version

$ go version
go version go1.17.3 linux/amd64

Go Tests

$ go test
PASS
ok      github.com/jaswdr/faker 0.779s