jaswdr / faker

:rocket: Ultimate fake data generator for Go with zero dependencies
https://pkg.go.dev/github.com/jaswdr/faker
MIT License
549 stars 59 forks source link

feat: added Bitcoin address generation #86

Closed xlanor closed 2 years ago

xlanor commented 2 years ago

Description

Added Bitcoin address generation based on discussion in #78

Are you trying to fix an existing issue?

78

Go Version

abc@c63bccef3747:~/workspace/oss/faker$ go version
go version go1.17.3 linux/amd64

Go Tests

abc@c63bccef3747:~/workspace/oss/faker$ go test
PASS
ok      github.com/jaswdr/faker 5.644s
abc@c63bccef3747:~/workspace/oss/faker$ 
codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (4ce91cb) into master (6edc0b2) will increase coverage by 0.30%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   91.25%   91.55%   +0.30%     
==========================================
  Files          35       36       +1     
  Lines        1063     1101      +38     
==========================================
+ Hits          970     1008      +38     
  Misses         72       72              
  Partials       21       21              
Impacted Files Coverage Δ
crypto.go 100.00% <100.00%> (ø)
faker.go 88.14% <100.00%> (+0.09%) :arrow_up:
music.go 85.71% <0.00%> (-7.15%) :arrow_down:
person.go 81.66% <0.00%> (-1.67%) :arrow_down:
address.go 97.26% <0.00%> (ø)
internet.go 90.83% <0.00%> (+0.83%) :arrow_up:
payment.go 100.00% <0.00%> (+20.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6edc0b2...4ce91cb. Read the comment docs.

xlanor commented 2 years ago

Changes made as reuqested!

jaswdr commented 2 years ago

LGTM, merged 👍