search

jaswdr / faker

:rocket: Ultimate fake data generator for Go with zero dependencies
https://pkg.go.dev/github.com/jaswdr/faker
MIT License
566 stars 59 forks source link

Improving code coverage #90

Closed jaswdr closed 2 years ago

jaswdr commented 2 years ago

Description

Replace this line with a short description of your changes

Improve code coverage to catch more errors and make coverage predictable.

Replace this line with a link to the issue you are trying to fix

Go Version

$ go version
go version go1.17.6 linux/amd64

Go Tests

$ go test
PASS
ok      github.com/jaswdr/faker 0.702s
codecov[bot] commented 2 years ago

Codecov Report

Merging #90 (694d69b) into master (941c731) will increase coverage by 5.37%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   91.67%   97.05%   +5.37%     
==========================================
  Files          36       36              
  Lines        1117     1085      -32     
==========================================
+ Hits         1024     1053      +29     
+ Misses         68       27      -41     
+ Partials       25        5      -20
Impacted Files Coverage Δ
address.go 100.00% <100.00%> (+5.47%) :arrow_up:
company.go 100.00% <100.00%> (+8.33%) :arrow_up:
faker.go 91.69% <100.00%> (+0.79%) :arrow_up:
image.go 100.00% <100.00%> (+15.38%) :arrow_up:
internet.go 96.46% <100.00%> (+2.29%) :arrow_up:
lorem_flickr.go 100.00% <100.00%> (+68.96%) :arrow_up:
music.go 100.00% <100.00%> (+21.42%) :arrow_up:
payment.go 100.00% <100.00%> (ø)
person.go 98.14% <100.00%> (+18.14%) :arrow_up:
phone.go 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 941c731...694d69b. Read the comment docs.