search

jaswdr / faker

:rocket: Ultimate fake data generator for Go with zero dependencies
https://pkg.go.dev/github.com/jaswdr/faker
MIT License
549 stars 59 forks source link

Refactoring Crypto generator #99

Closed jaswdr closed 2 years ago

jaswdr commented 2 years ago

Description

Refactoring existing Crypto generator to align with the project standards.

Also, fixing Currency test by removing check for empty string in currency code, since it is a value.

Are you trying to fix an existing issue?

No.

Go Version

$ go version
go version go1.18.3 linux/amd64

Go Tests

$ go test
PASS
ok      github.com/jaswdr/faker 1.397s
codecov[bot] commented 2 years ago

Codecov Report

Merging #99 (e420194) into master (fcf112c) will increase coverage by 1.56%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   95.66%   97.22%   +1.56%     
==========================================
  Files          36       36              
  Lines        1085     1083       -2     
==========================================
+ Hits         1038     1053      +15     
+ Misses         39       24      -15     
+ Partials        8        6       -2
Impacted Files Coverage Δ
crypto.go 100.00% <100.00%> (ø)
person.go 92.59% <0.00%> (-1.86%) :arrow_down:
faker.go 92.49% <0.00%> (+3.95%) :arrow_up:
internet.go 97.34% <0.00%> (+5.30%) :arrow_up:
phone.go 100.00% <0.00%> (+7.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcf112c...e420194. Read the comment docs.