jaszhix / icingtaskmanager

Window list with app grouping and thumbnails for Cinnamon
https://cinnamon-spices.linuxmint.com/applets/view/269
GNU General Public License v2.0
60 stars 12 forks source link

Per-monitor windows not being respected when the mode is enabled #174

Closed sphh closed 6 years ago

sphh commented 6 years ago

Bug report:

Describe the steps needed to be taken in order to reproduce this bug.

I have a dual monitor set-up with a panel across each monitor. I also have two instances of ITM running which should display only the windows from one monitor. What I get is:

image

In this screenshot everything left of the Linux Mint Menu is on the left monitor. The windows are placed as follows:

Conclusion:

Other (minor) issues I noticed

jaszhix commented 6 years ago

You need to select "Only list windows from the monitor displaying this instance" for this feature to work.

sphh commented 6 years ago

That is what I did. To be sure, I checked both json files attached and either has the following section:

    "list-monitor-windows": {
        "type": "checkbox",
        "default": false,
        "description": "Only list windows from the monitor displaying this instance",
        "tooltip": "This option will only come into effect for monitors displaying an ITM instance.",
        "value": true
    },

I would think that turns this feature on.

jaszhix commented 6 years ago

Ah sorry, I was mistaking the default property as the value on my quick glance through them.

sphh commented 6 years ago

No worries. Thank you for looking into it.

If I can help with anything (log files, ...), please drop be a line.

jaszhix commented 6 years ago

After attempting to reproduce the main issue, I realized this is actually caused by pinned apps showing no matter what. If you're not using Cinnamon favorites for pinned apps, you can customize which pinned apps you'd like to see on each monitor, or you can disable "Show pinned apps" for that ITM instance. I think this is expected behavior, so closing this one for now.

As for the other issues:

sphh commented 6 years ago

I thought that every instance of ITM has its own "pinned applications" are. Looks like I am wrong. I disabled the "Show pinned apps" on the instance of ITM on my left monitor. Still I have my LibreOffice Calc and Waterfox window displayed on both monitors (both programs have just one window open): image IcingTaskManager@json.zip For Thunderbird an icon is shown on the second screen asking for attention, but there is no window on the second screen.

I also experience the following feature: I open a nemo window (IcingTaskManager...) on the primary monitor: image Then I right-click on it in the window list and select Move to the other monitor. The nemo window moves, but the window list of the first monitor still shows the window: image When I move it back by dragging the nemo window to the first monitor, the window list only shows the icon, but no title: image Only when I select the window, the full title is shown.

As far as I am concerned, this bug unfortunately still exists.

BTW I am on the most recent ITM v 6.1.0

jaszhix commented 6 years ago

Okay, it seems to be treating the primary monitor differently after testing again. Your original issue describes both instances showing apps across monitors, and the apps you said were on both were also pinned, so it seemed like a false positive. I'll re-open so this can be addressed further. Its also a good idea to keep issues focused on one problem, just one bug alone can be complicated to deal with.

sphh commented 6 years ago

Sorry for adding the other (minor) issues. These were not thought as bug reports (because they were already addressed in other reports), just as observations. You are right, I should have added comments to these other report. Thanks for sorting that mess.

jaszhix commented 6 years ago

No problem, thanks for reporting the issue.