jaszhix / icingtaskmanager

Window list with app grouping and thumbnails for Cinnamon
https://cinnamon-spices.linuxmint.com/applets/view/269
GNU General Public License v2.0
61 stars 12 forks source link

Bug: app stay focused after minimized #177

Closed Ocelot92 closed 6 years ago

Ocelot92 commented 6 years ago

Hi, the new version fixed the #176 bug (thanks!), but i found another one (+ a possible solution). Basically I get the app focused evenw hen minimized. This can lead to have even two app with style "focused". setting To reproduce the bug (app focused when minimized):

  1. Open an app (calculator for instance)
  2. Minimize it by clicking the icon on the taskbar
  3. Move the mouse away from the taskbar This is what you should get: calculator focused

Messing around with the app you cen get even the two app focused bug, which is related to the same behaviour: 2 app focused

I edited the appGroup.js by commenting the lines 539 to 549 and 565 and this fixed the bug. You could check it here: appGroup.js.fixed.tar.gz

As far as i know there are no bugs introduced by commenting those lines.

jaszhix commented 6 years ago

Commenting out the closed pseudo selector removal will break the styling fix for distinguishing between open/closed apps for the Mint X based themes. That pseudoClassStash might be able to be removed for lines 539-545, it was originally intended for restoring the active and focus pseudo classes if they're used to substitute the hover pseudo class, but I recently found out disabling track_hover on the actor fixed that. Will have to test more later, thanks!