jaszhix / icingtaskmanager

Window list with app grouping and thumbnails for Cinnamon
https://cinnamon-spices.linuxmint.com/applets/view/269
GNU General Public License v2.0
60 stars 12 forks source link

Multiple window icons created when using imagemagick "display" command #183

Closed asquartz closed 6 years ago

asquartz commented 6 years ago

Hello, if I use imagemagick to display a series of images using imagemagick, for example display ~/Pictures/*, each time you press space to move to the next picture, another new icon is created in the task manager, with a red "no entry" logo. These persist after imagemagick is closed. To make them go away, I have to go into ITM Configuration and toggle "Group Apps" off and then back on again.

Thanks.

I've attached a picture of the problem, and the three requested logs. Cinnamon 3.6.7, ITM version 6.0.4, Linux Mint 18.3, Mint-Y theme

icingtm

15.json.txt glass.log.txt xsession-errors.txt

jaszhix commented 6 years ago

Not sure how to reproduce this, when I try to display a directory of images it just crashes.

display ./apps
display: no decode delegate for this image format `' @ error/constitute.c/ReadImage/501.

The apps seem to be grouped properly when I open a dialog.

This might be related to the fix for #182 - attached the version from the itm-621 branch on my spices fork there. Does that version work better?

jaszhix commented 6 years ago

Oh, just noticed you're on ITM 6.0.4. That version is out of date. Refresh your applet cache and upgrade please. If the issue remains, try the version I attached in #182.

asquartz commented 6 years ago

Thank you for replying. I updated to 6.2.0 (the latest offered by Mint), and then applied your version (taking it to 6.2.1) but unfortunately neither of these fixed the issue.

Noting your comment above about how to reproduce, you need to put the wildcard at the end of the display command: `display ./apps/ordisplay ./apps/*.jpg` depending what else is in the directory. Display gets upset if you ask it to display things that aren't images. :)

Regarding the possible link to #182, I do get context menus on my icons, however I notice that whilst an image is being displayed, all of the "display" icons show a preview of the current image, and a full context menu. After i quit the "display" command, all the icons display a blank thumbnail and a much shorter context menu containing only "Visible on all workspaces", "move to another workspace", "Preferences" and "Create Shortcut".

I had a further look, and I think this is caused by the little "pan window" that imagemagick opens if the displayed image is large (enables you to drag around the image). Photos from my camera cause the pan window to be displayed, and the ITM error occurs. However if I type, for example, display ~/.local/share/icons/hicolor/128x128/apps/*, all the images are small so the pan window does not appear, and the bug does not occur. Hope this helps :)

jaszhix commented 6 years ago

Thanks, I was able to use the slideshow after that. Unfortunately it worked as expected and only opened one window. I'm wondering if this is more dependent on settings and environment. I noticed this in your logs:

(cinnamon:8046): Cjs-WARNING **: JS ERROR: TypeError: this.listState is undefined
AppGroup.prototype._onAppChange@/home/andy/.local/share/cinnamon/applets/IcingTaskManager@json/3.2/appGroup.js:883:5

Which is a side effect I've observed from the method I'm using to help prevent memory leaks in ITM (#168). It could be cleaning up an app button instance too early, and causing the bug you're seeing.

jaszhix commented 6 years ago

I can't reproduce this still, so closing - feel free to open another issue if its still occurring on 6.3.10.

asquartz commented 6 years ago

I'm still on 6.2.1 in the Mint applet store, but I've worked around it by using options in the "display" command so that the pan window is not shown. When we get the new version of ITM on Mint I'll test it again. Thanks.