search

jaszhix / icingtaskmanager

Window list with app grouping and thumbnails for Cinnamon
https://cinnamon-spices.linuxmint.com/applets/view/269
GNU General Public License v2.0
60 stars 12 forks source link

Consistent Flatpak pinning support in ITM when debian version of application is present. #229

Closed smurphos closed 6 years ago

smurphos commented 6 years ago

Hi jaszhiz,

There a are a few inconsistencies in the way ITM handles flatpak app pinning when there is also a debian packaged version of the app installed which I hope can be resolved and also included in the fork ADW for Cinnamon 4. This issue is also partly prompted by this 18.3 users experience with snap package pinning - https://github.com/jaszhix/icingtaskmanager/issues/228, which was also raised on the Mint forum. I'm not sure if the same underlying issues cause the inconsistency with snap.

For this testing I've used VLC

Preinstalled version is 3.03 - desktop file is usr/share/applications/vlc.desktop

Flatpak version is 3.04 - desktop file is /var/lib/flatpak/app/org.videolan.VLC/current/active/export/share/applications/org.videolan.VLC.desktop There is also a symlink in /var/lib/flatpak/exports/share/applications/org.videolan.VLC.desktop

Test 1 - Launch VLC flatpack from the menu, right click on icon and select pin to panel. Result - vlc.desktop is pinned Preferred result - org.videolan.VLC.desktop should be pinned.

Test 2 - Right click Flatpak VLC in menu and select add to panel. Result - org.videolan.VLC.desktop is pinned Launching from the pinned icon launches the correct version of VLC but another VLC icon is added to ITM, it doesn't group/count the window under the pinned org.videolan.VLC.desktop Preferred result - Correct grouping of the window.

Test 3 - Use the menu editor to rename the Flatpack VLC entry to VLC Flatpak. This creates a new desktop file - _/.local/share/applications/org.videolan.VLC.desktop Repeat test 1 - same result Repeat test 2 - same result

Test 4 - Use the menu-editor to create a new user added menu entry targeting the flatpak version. Repeat test 1 - same result Repeat test 2 - same result

Test 5 - Use a different flatpak without a corresponding debian installed version. I used Oomox for testing - desktop file is /var/lib/flatpak/app/com.github.themix_project.Oomox/current/active/export/share/applications/com.github.themix_project.Oomox.desktop with a symlink in /var/lib/flatpak/exports/share/applications/com.github.themix_project.Oomox.desktop

Retried test 1 - works fine with no unexpected results. Retried test 2 - works fine with no unexpected results.

Contents of org.videolan.VLC.desktop https://pastebin.com/wme6TLp1 Contents of vlc.desktop https://pastebin.com/1ey72Hv4

jaszhix commented 6 years ago

I think I've encountered this as well with VLC. I'm not sure what a good solution for that would be just yet, I think the problem for some reason or another, while it has a desktop file in the flatpak dir, it launches itself as a window backed app. In these causes though, it can be worked around by dragging the icon from the menu to ITM.

smurphos commented 6 years ago

I guessed it wouldn't be an easy fix. I just think that when Cinnamon 4 gets out to the masses you'll have a stream of issues on this. Maybe if Clem untied the vlc dependency from mint-meta-codecs you can at least say that ITM/AWL does not fully support having both a Flatpack and debian version of the same application installed and advise to uninstall one or the other.

jaszhix commented 6 years ago

I think this should be moved to the CInnamon repo. I'm finding a bug in the menu where I can't even launch the Flatpak version of the app if the Debian version is running and vice versa. More people can analyze it there, and a proper solution probably won't exist in applet code.

jaszhix commented 6 years ago

Kamino closed and cloned this issue to linuxmint/Cinnamon