Closed jeffslofish closed 5 years ago
Hi, good catch. I can fix this, or you can PR. Either works. Thanks.
Why don't you go ahead and fix it. I looked into it and there are a few different ways to do it and I wasn't sure which you would like the best.
After doing a git clone and then running
yarn
I attempted to runnpm run build-chrome
per the contributing instructions and I get errors, beginning with:I noticed that if I created the "dist" directory manually, then the error goes away and traced the problem to line 33 in webpack.config.js which is assuming that the ${WORKDIR} directory exists, which is "dist" in this case.
It would be nice if the "dist" directory was automatically created if it doesn't exist, so that the first time you try to build it won't fail, since the "dist" directory is not included in the repo.
I could create a pull request to fix this if you like.