Use native child windows, not fake ones.

[RokeJulianLockhart]

If it's possible (it is) to use the window manager, why re-invent the wheel? Otherwise, keep a strictly page-based view and use the omnibox to set different URIs for each page so that it can be navigated like any other website.

[jaszhix]

Are you suggesting opening the settings page in a new tab like the alternative options.html view (opened from within Chrome settings)? I don't understand the request, but do see your tone is frustrated. No wheels were reinvented, in-page modals are fairly ubiquitous in web applications.

[RokeJulianLockhart]

@jaszhix,

---

but do see your tone is frustrated

I'm not frustrated. This isn't a major problem, only a pleasant improvement if implemented. Though it would be brilliant.

Are you suggesting opening the settings page in a new tab like the alternative options.html view (opened from within Chrome settings)?

Exactly that, because that provides the most versatility. I would be able to extract it to a dedicated window if I drag the tab out (which the current implementation doesn't allow). Alternatively, I would be able to have it as a tab (which having it open a dedicated separate window would not allow).

No wheels were reinvented, in-page modals are fairly ubiquitous in web applications.

They're not mutually exclusive. Most of the web re-implements native WM functionality, usually because they're restricted from local access since IE6 made so many peoples' PCs blow up.

---

Thanks.

[jaszhix]

I understand the WM point, I just took issue with framing the intent of modal usage so negatively. One issue I have with the suggestion is how to ensure a side by side color swapping preview with the theme editor. This is something that can be done by the user themselves with their WM of choice, but not all users have access to WMs with good tiling (e.g. macOS) and it could become more tedious for some people.

[RokeJulianLockhart]

@jaszhix, I'm unsure what you mean by

side by side color swapping preview with the theme editor

Can you illustrate it somehow?

[jaszhix]

It's the Theming section of the settings modal, it resizes itself so you can see a preview of the changes.

[RokeJulianLockhart]

Why not use https://www.naiveui.com/en-US/os-theme/components/color-picker#native.vue instead? (Not specifically from that framework, just the native colour picker.)

[jaszhix]

On Windows, that doesn't seem to open the native color picker in Chrome.

[RokeJulianLockhart]

@jaszhix, try https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color

[jaszhix]

That one seems to work as I'm unable to halt page execution in devtools while it's open, though it's using a color picker I'm not familiar with. Seems like a good way to shed some bytes off the bundle size, but not sure the resource usage, or user experience would be noticeably different. If you'd like to implement this in a PR (or have a way to make the settings work in a new window while keeping UX intact for existing users), I would be receptive to that change.