jatcwang / difflicious

Scala library for readable diffs of values
Apache License 2.0
74 stars 4 forks source link

difflicious and diffx #26

Open ghostbuster91 opened 1 year ago

ghostbuster91 commented 1 year ago

Hi,

I tried reaching you out on twitter but the tweet must've got lost among others. I always thought that the way you designed difflicious internals is superior to what I did in diffix, but up until that moment I was able to implement everything I needed in diffx. Recent bug issue(https://github.com/softwaremill/diffx/issues/418) pointed out some flaws in the diffx that cannot be fully fixed without major rewrite of internals. Of course, I could make that rewrite but that would mean doing basically the same thing what you did in difflicious. I don't really see a point in fixing diffx that way, when there is already a better version of it implemented :) While implementing diffx and later maintaining it was a great journey for me, I think that objectively the best I can do now is to deprecate it and redirect users to your library. However, there are some users of diffx out there and I would like to do it right, and provide a smooth transition for them.

First, I would like to make sure that you are planning to maintain difflicious and you have a capacity to do that. These days my capacity is fairly limited by other projects but I will be happy to help if you need any help. Second, I am considering writing a scalafix rule to ease the migration. I guess rewriting imports and class names would cover most of the cases. Do you think it is a good idea? Third, difflicious doesn't support automatic derivation. I understand reasoning behind that decision. I never use auto derivation in my own projects. Still, there are some people that do, and it is a nice feature especially when prototyping/ trying out new things. Would you consider adding it? (maybe it could be done as a separate module?)

jatcwang commented 1 year ago

Hi @ghostbuster91 thanks for the kind words. Yeah I did not receive any message from you on Twitter..definitely had similar things happen before 🤔

ghostbuster91 commented 1 year ago

Understood and thank you. I won't have much time before December but after that I can try contributing the auto-derivation. It seems that we have some vague plan of moving forward. So to sum up:

Let me know if you think that something is missing or should be done in different order.

jatcwang commented 1 year ago

Yep sounds good to me thanks!