search

jatcwang / difflicious

Scala library for readable diffs of values
Apache License 2.0
74 stars 4 forks source link

Feedback after migrating from diffx #29

Open ghostbuster91 opened 1 year ago

ghostbuster91 commented 1 year ago

The purpose of this issue is to gather feedback from migrating projects to difflicious.

https://github.com/ghostbuster91/pgn-parser/pull/2 - .assertNoDiff has to be called on the differ instance. For more complex types it is cumbersome. It would be better to write it in a way where the type can be inferred from the passed arguments.

kostaskougios commented 3 months ago

Yes me too. I just gave a try to the library but gave up when I realized what I have to do something like Diff[Seq[Player]].assert... . I think something like Diff.assertNoDiff(a1,a2) that infers the type would be a lot simpler.

2m commented 1 month ago

I also recently migrated from diffx and I am using this assertion method variation from the munit support:

https://github.com/2m/rallyeye/blob/391227a93eb4b608416b6745595280d2c9ac04aa/modules/backend/src/test/scala/difflicious.scala#L24-L26