search

jatcwang / difflicious

Scala library for readable diffs of values
Apache License 2.0
74 stars 4 forks source link

Add integration for Weaver test framework #30

Closed gregorath closed 11 months ago

gregorath commented 11 months ago

hello, thanks for this project.

With this PR we are adding support for the weaver framework and I followed the structure of the scalatest module. I didn't open an issue before as I think this is a small change.

gregorath commented 11 months ago

it looks like there is incompatibility between the scala 3 versions from weaver and difflicious. would it be ok to upgrade to 3.2.2 or even to the LTS 3.3.0 one? I tested it locally and seems okay. sorry I didn't realise I had to pass the 3 version for the compilation command before opening the PR

jatcwang commented 11 months ago

@gregorath Yes we should upgrade to 3.3.0 feel free to modify in this PR (will need to run sbt githubWorkflowGenerate to regenerate ci.yaml too). Don't worry about forgetting to run all 3 compile versions. That's what CI's for :) Thanks!

gregorath commented 11 months ago

okay version updated 👍

gregorath commented 11 months ago

and I had to update the expected error message in one of the tests, done in 0d1a59a