search

jathanism / do_auth

A post-authorization script for tac_plus to allow greater flexibility in TACACS+ authentication and authorization controls.
tacacs.org
GNU General Public License v3.0
25 stars 9 forks source link

Python 3 compatibility #3

Closed ragzilla closed 10 years ago

ragzilla commented 10 years ago

Tested against: 2.4.3 (for itertools.product compatibility), 2.6.6, and 3.3.2

Python3 adds some additional functionality in os (getgrouplist) which may be useful in environments where people want to pull NSS group lists.

ragzilla commented 10 years ago

Looks like this also pulled in a commit I just made to use getgrouplist in Python3 os module to pull in NSS groups. Allows for groups to be set up centrally (ldap, nis, etc).

jathanism commented 10 years ago

Hi @ragzilla! Thanks for the patch. We're reviewing it!

helpdeskdan commented 10 years ago

getgrouplist for nss. I like it.

jathanism commented 10 years ago

This looks great, thank you! So I have two more minor things and then we'll merge it in:

  1. Increment the version in do_auth.py to 1.11
  2. Update CHANGELOG.rst to include the changes made!

Thanks again! :)

ragzilla commented 10 years ago

version bumped and changelog updated