jatinchowdhury18 / AnalogTapeModel

Physical modelling signal processing for analog tape recording
GNU General Public License v3.0
1.12k stars 64 forks source link

Fix a typo in boundPhase of flutter process #290

Closed phoracek closed 2 years ago

phoracek commented 2 years ago

Studying the code I stumbled upon this and I suspect it is just a copy-paste error.

Kudos for this cool repo and the white paper.

ghost commented 2 years ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=290&src=https%3A%2F%2Fgithub.com%2Fjatinchowdhury18%2FAnalogTapeModel)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

jatinchowdhury18 commented 2 years ago

Thanks for the fix! Yeah, just a typo most likely! CI looks good as well (don't worry about the failures, they aren't caused by this change).

If you could please switch this PR to target the develop branch, then I'll be happy to merge it!

phoracek commented 2 years ago

Sure thing, done o/