jatinchowdhury18 / AnalogTapeModel

Physical modelling signal processing for analog tape recording
GNU General Public License v3.0
1.06k stars 60 forks source link

LV2: Support stereo mode only #300

Closed iv-m closed 1 year ago

iv-m commented 1 year ago

LV2 does not support setting number of channels dynamically, so, to avoid confusing hosts with 36-channels plugin and to preserve compatibility with older LV2 plugins, the LV2 plugin now reports supporting stereo mode only.

Refs. https://github.com/jatinchowdhury18/AnalogTapeModel/issues/283

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=300&src=https%3A%2F%2Fgithub.com%2Fjatinchowdhury18%2FAnalogTapeModel)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

jatinchowdhury18 commented 1 year ago

Everything seems okay in my local testing! Merging...

iv-m commented 1 year ago

@jatinchowdhury18, thank you for such quick review, and for being so supportive. And thank you for this truly awesome plugin btw =)