jaukia / zoomooz

An easy-to-use jQuery plugin for making zooming web pages.
http://janne.aukia.com/zoomooz/
1.79k stars 275 forks source link

affineTransformDecompose more rigidly checks for singularity #108

Closed ambuc closed 9 years ago

ambuc commented 9 years ago

As noted in https://bugzilla.mozilla.org/show_bug.cgi?id=531344, the matrix needs to be checked for singularity. I think that checking for Math.abs(a*d-b*c)<0.01 as a functional approximation is too rigid - i'm working with a project where the window to be transformed is very long and thin, and the affineTransformDecompose function regularly throws "fail!" at me. No worries if you want to keep it rigid - thought you should know.

jaukia commented 9 years ago

Merged, thanks!