search

jaukia / zoomooz

An easy-to-use jQuery plugin for making zooming web pages.
http://janne.aukia.com/zoomooz/
1.79k stars 275 forks source link

Allow Propogation #58

Closed jackmoore closed 11 years ago

jackmoore commented 11 years ago

Changed event.stopPropagation to event.preventDefault. This should allow other scripts to also act on click events, but I don't know enough about your plugin to know if this causes undesirable behavior (did not test).

If you are depending on the event not bubbling, then you should probably explore an alternative solution, such as checking what the target was, rather than stopping all propagation.

jaukia commented 11 years ago

Thanks for the suggestion! I cannot merge the pull request in, since you have modified the jquery.zoomooz.js directly, instead of modifying the source files that are located in "src/js/". To build the source files, "cd src; jake".

The preventDefaults would probably be ok for the event handlers, to be honest, I don't recall why they are placed there.

jaukia commented 11 years ago

Hi,

Thanks for the suggestion! I cannot merge the pull request in, since you have modified the jquery.zoomooz.js directly, instead of modifying the source files that are located in "src/js/". To build the source files, "cd src; jake".

The preventDefaults would probably be ok for the event handlers, to be honest, I don't recall why they are placed there. Target detection might be needed.

-janne

On 28 February 2013 21:12, Jack Moore notifications@github.com wrote:

Changed event.stopPropagation to event.preventDefault. This should allow other scripts to also act on click events, but I don't know enough about your plugin to know if this causes undesirable behavior (did not test).

If you are depending on the event not bubbling, then you should probably explore an alternative solution, such as checking what the target was, rather than stopping all propagation.

You can merge this Pull Request by running

git pull https://github.com/jackmoore/zoomooz master

Or view, comment on, or merge it at:

https://github.com/jaukia/zoomooz/pull/58

Commit Summary

allow propogation Allow propagation (again). Fixes #54

File Changes

M jquery.zoomooz.js (20)

Patch Links:

https://github.com/jaukia/zoomooz/pull/58.patch https://github.com/jaukia/zoomooz/pull/58.diff

jaukia commented 11 years ago

I added a new ticket on this without the pull request: https://github.com/jaukia/zoomooz/issues/59