search

jaumard / ngx-dashboard

Dashboard library for angular 4 and more
https://jaumard.github.io/ngx-dashboard/demo/demoDist/index.html
MIT License
71 stars 31 forks source link

AfterViewInit upgrade #27 #38

Closed LiamDotPro closed 6 years ago

LiamDotPro commented 6 years ago

This Fixes bug #27 It's a short fix but it may be better to handle this directly from the native resize function or you could probably just move your entire OnInit inital resize call to an afterview init so the resize has vision of the DOM elements.

LiamDotPro commented 6 years ago

This PR might actually need a revision, just noticed while the dashboard functions as intended it raises a ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked.

LiamDotPro commented 6 years ago

Further testing on our end shows that the above closes #27, Also at the same time I will try and find the time to submit a bootstrap theme. I also want to raise another issue to try and fix or add smoothing between components moving within the dashboard.

If I manage this from my forked version I'll submit another PR, meanwhile can you please review this.

jaumard commented 6 years ago

Hello :) sorry about the delay I totally forget about this PR :/ Looks good to me :)

Thanks for this !