jaumard / sms_autofill

Flutter plugin to provide SMS code autofill support
MIT License
281 stars 173 forks source link

handled onActivityResult exceptions #199

Closed anirudhsharma392 closed 7 months ago

anirudhsharma392 commented 1 year ago

This PR resolves the issue. Handled the app crash inside OnActivityResult.

AnirudhLoya commented 11 months ago

By when this PR be merged to production & new update be released for #33 crash issue?

danishkhawaja98 commented 11 months ago

@jaumard Please merge this PR.

danishkhawaja98 commented 11 months ago

Hi @jaumard

Just like what you have done on Line # 17 to Line # 25 on dart code and Line # 85 to Line # 87 on android code, we also need to implement the same method on Line # 30 on dart code and Line # 99 on android code to resolve this crash issue.

Reference attachment

AnirudhLoya commented 11 months ago

Pls merge if crash issue is resolved.

On Mon, Jul 31, 2023 at 7:02 PM Danish Khawaja @.***> wrote:

Hi @jaumard https://github.com/jaumard

Just like what you have done on Line # 17 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/lib/sms_autofill.dart#L17C5-L17C5 to Line # 25 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/lib/sms_autofill.dart#L25 on dart code and Line # 85 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/android/src/main/java/com/jaumard/smsautofill/SmsAutoFillPlugin.java#L85 to Line # 87 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/android/src/main/java/com/jaumard/smsautofill/SmsAutoFillPlugin.java#L87 on android code, we also need to implement the same method on Line # 30 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/lib/sms_autofill.dart#L30 on dart code and Line # 99 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/android/src/main/java/com/jaumard/smsautofill/SmsAutoFillPlugin.java#L99 on android code to resolve this crash issue. Reference attachment

- https://stackoverflow.com/questions/65666404/java-lang-illegalstateexception-reply-already-submitted-when-trying-to-call

— Reply to this email directly, view it on GitHub https://github.com/jaumard/sms_autofill/pull/199#issuecomment-1658380447, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK52ZRVBEXA3VTXDJQZ3BDXS6XWRANCNFSM6AAAAAAYWUU3RQ . You are receiving this because you commented.Message ID: @.***>

--

Thank you

Aniruddh Loya

danishkhawaja98 commented 11 months ago

Pls merge if crash issue is resolved. On Mon, Jul 31, 2023 at 7:02 PM Danish Khawaja @.> wrote: Hi @jaumard https://github.com/jaumard Just like what you have done on Line # 17 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/lib/sms_autofill.dart#L17C5-L17C5 to Line # 25 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/lib/sms_autofill.dart#L25 on dart code and Line # 85 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/android/src/main/java/com/jaumard/smsautofill/SmsAutoFillPlugin.java#L85 to Line # 87 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/android/src/main/java/com/jaumard/smsautofill/SmsAutoFillPlugin.java#L87 on android code, we also need to implement the same method on Line # 30 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/lib/sms_autofill.dart#L30 on dart code and Line # 99 https://github.com/jaumard/sms_autofill/blob/7b5234c007267bee0e565a1fd50ec0b4a6d97063/android/src/main/java/com/jaumard/smsautofill/SmsAutoFillPlugin.java#L99 on android code to resolve this crash issue. Reference attachment - https://stackoverflow.com/questions/65666404/java-lang-illegalstateexception-reply-already-submitted-when-trying-to-call — Reply to this email directly, view it on GitHub <#199 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK52ZRVBEXA3VTXDJQZ3BDXS6XWRANCNFSM6AAAAAAYWUU3RQ . You are receiving this because you commented.Message ID: @.> -- Thank you Aniruddh Loya

I don't have the write access, @jaumard has. The crash issue is resolved, but the phone number is displayed on the field when we click two times on the phone number from the dialog that appears.

jaumard commented 7 months ago

Thanks for this, sorry for the delay

debojyoti452 commented 7 months ago

@jaumard The last release was nine months ago. When can we expect this fix to be published?