search

jaumard / sms_autofill

Flutter plugin to provide SMS code autofill support
MIT License
289 stars 184 forks source link

Sim card detection #86

Closed grahamsmith closed 3 years ago

grahamsmith commented 3 years ago

Fix for #85

grahamsmith commented 3 years ago

@jaumard - I noticed a few potential bugs in the Android native code. They would be safely eliminated with null checks however I would suggest moving to Kotlin as this would help avoid the problem as well as make the code easier to understand.

I can do this work in another PR but just a heads up.

jaumard commented 3 years ago

I like Kotlin when doing android apps, but I hate it when doing flutter plugins, not because of the langage, but because it need specific version on build.gradle, and each plugin have his own version that can conflict sometime. Same goes for Swift on iOS side. That's why I tried to do all my plugins in java and ObjC only. So no need to transform it to Kotlin I'll not accept those changes.

Thanks for this fix! Look good to me!