search

jaunesarmiento / fries

Fries helps you prototype Android apps using HTML, CSS, and JavaScript.
MIT License
1.55k stars 222 forks source link

Replace current icon set with a more complete set #34

Closed jaunesarmiento closed 10 years ago

jaunesarmiento commented 11 years ago

Merging issues #27 and #21.

The current icon set still lacks a few official Android icons such as the refresh and power/logout icons.

morgansoftware commented 11 years ago

Also, the 'menu' icon is missing - the one that has three horizontal lines. I don't think that this is included in the Android Icons pack (http://developer.android.com/design/style/iconography.html), so I don't think android provides it's own. So the menu icon must be a custom icon, but regardless, It would make my life a bit easier to have this icon already included with fries - because I've used that icon on almost every project I've worked on. Hope to see it soon. And thanks for fries!

jaunesarmiento commented 11 years ago

Hi @KyleMorgan49, I can't seem to find what the "menu" icon looks like on Android. Do you mind providing a screenshot of the icon?

The current iconset includes the following icons from the original repo: http://turbo87.github.io/Android-Action-Bar-Icon-Pack-Font/ Please note that the class names may differ from this list.

jaunesarmiento commented 11 years ago

Also, I'm having issues regarding the licensing of the Android official icons and @turbo87 's Action Bar Icon Pack Font. I'm thinking of redoing the icon font myself and licensing it using MIT so Fries users don't need to attribute them to the original author.

The Android official icons are (I believe) licensed under Creative Commons 2.5. Which is annoying cause you have to attribute it to the Android Open Source Project.

Any thoughts about this?

jaunesarmiento commented 11 years ago

Oops, sorry. I misread your post. I didn't see the "three horizontal lines". Got it.

morgansoftware commented 11 years ago

Yes, Action Bar Icon Pack is licensed under CC2.5. I don't know a whole lot about that license though. I wonder if it would be better to custom make this icon as an svg image and not include it in the icon pack. Also if you decide to remake ALL the icons, please be very careful. The point of fries is to look like android. The icons are the big give-away. If the icons look any different (even the slightest bit) then it just looks like some bad knock off. So if you do go down this route, I don't know how much you know about iconography but, I'd suggest reading the link I provided in my original comment, and this here http://www.behance.net/gallery/Google-Visual-Assets-Guidelines-Part-1/9028077 (there are two parts)

jaunesarmiento commented 11 years ago

I meant redoing the font iconset from SVG and converting them into a font and release it under MIT. So Fries users can just attribute their works to the Android Open Source Project instead of having to put so many licensing stuff on their work. I'm not sure if that's possible though.

Turbo87 commented 11 years ago

Hi @jaunesarmiento, please read the discussion that we had about this issue at https://github.com/Turbo87/Android-Action-Bar-Icon-Pack-Font/issues/2

tl;dr: we figured that since the original icon set is CC-BY-2.5 we didn't really have the option to license the webfont under anything less restrictive, without suggesting to the user that he doesn't have to attribute anyone. I'm happy to relicense though if it is possible and legal.

jaunesarmiento commented 11 years ago

@Turbo87, yes I'm having the same issues as you are right now. I don't have the time (yet) to research on the matter but I'd be more than willing to be less restrictive on this matter as well. But as far as Fries is concerned, I think I already made the changes I need to do to both the website (documentation) and the README to properly attribute the icons to the Android Open Source Project and to you. If this however does not suffice your requirements for attribution, please by all means, tell me so I can make the changes.

Turbo87 commented 11 years ago

@jaunesarmiento as I mentioned in the issue, I'm not actually that interested in the attribution, I only chose the license to be compatible with the original iconset. Looks alright :)

jaunesarmiento commented 11 years ago

Alright man, cool. :) Thanks for clarifying this. Cheers!

teusink commented 11 years ago

I have not read the entire discussion (on holiday :), but the original Android menu icon (3 horizontal stripes) can be found in the sdk (ic_drawer.png) or in jpHolo on GitHub (assets/www/images/icons).

Sorry in advance if I misinterperted the comments :).

jaunesarmiento commented 10 years ago

Couldn't find a more complete icon set. Closing this for now.