jav / expo-server-sdk-java

Expo server SDK in java
MIT License
21 stars 23 forks source link

[Maven Dist] Dependencies are explicitly included in core jar #33

Open ianmelendez95 opened 3 years ago

ianmelendez95 commented 3 years ago

Dependencies including org.aprache.commons.lang3 and com.fasterxml.jackson.* are in the core jar, which conflicts with dependency management provided by projects.

Please feel free to close this issue if my understanding is wrong, but I believe these dependencies should be delegated to Maven so that it can resolve these transitive dependencies against the parent projects configuration.

amagnolo commented 2 years ago

Unfortunately the lack of a maintainer is becoming a serious issue. Expo stated clearly that they won't take charge of this https://expo.canny.io/feature-requests/p/maintain-java-server-side-library-for-expo

jav commented 2 years ago

It's open to any one using the repo to take over maintainership. I strongly encourage you (plural you, anyone reading this) to please do so :)

On Thu, 30 Jun 2022 at 14:49, Alessandro Magnolo @.***> wrote:

Unfortunately the lack of a maintainer is becoming a serious issue. Expo stated clearly that they won't take charge of this https://expo.canny.io/feature-requests/p/maintain-java-server-side-library-for-expo

— Reply to this email directly, view it on GitHub https://github.com/jav/expo-server-sdk-java/issues/33#issuecomment-1171179307, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAQ2MIAHP3M64L4U2ACXTVRWJVRANCNFSM5AHJCDKQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rowi1de commented 2 years ago

@jav I'm trying to fix this particular issue, but won't have time to maintain the repo itself, as I'm not familiar with the project and also won't have time

jav commented 2 years ago

If you submit a PR, I'd be willing to merge it :)

I am making an effort to communicate and show that I don't have the bandwith to do this (i.e maintain the repo) on a regular basis :)

(there are several other PRs I haven't had the time to review nor merge)