search

java-deobfuscator / deobfuscator

The real deal
https://javadeobfuscator.com
Apache License 2.0
1.59k stars 295 forks source link

Optimi ParamorphismTransformer #766

Closed ghost closed 3 years ago

ghost commented 3 years ago

What Changed:

  1. Removed the field OVRERIDE since it's useless
  2. Moves the replace loop out side of the interface decryption loop.
ghost commented 3 years ago

@fee1-dead Why should ClassCast being removed ? It makes no sense. Please provide reasons.

Janmm14 commented 3 years ago

@fee1-dead Why should ClassCast being removed ? It makes no sense. Please provide reasons.

The idea is to classcast once (see first suggested change) and safe it in a new variable. Code looks cleaner then.

ghost commented 3 years ago

@Janmm14 not necessary i think

fee1-dead commented 3 years ago

Casting multiple times makes no sense. Do it once, and it saves space, makes the code easier to read.

fee1-dead commented 3 years ago

Even if the code ends up having the same behavior, style issues can develop and become a habit. Please fix this. It is quick and simple.

fee1-dead commented 3 years ago

Maintainers, I think you are allowed to edit, so maybe you can help him squash the commits?

ItzSomebody commented 3 years ago

Maintainers, I think you are allowed to edit, so maybe you can help him squash the commits?

It should be enabled by default, yes.

@BackupAccou: Is there a reason why you closed this?