java-james / flutter_dotenv

Loads environment variables from `.env`.
https://pub.dartlang.org/packages/flutter_dotenv
MIT License
209 stars 46 forks source link

Modified some edge cases and migrated to null-safety #24

Closed ngxingyu closed 3 years ago

ngxingyu commented 3 years ago

Implemented the following regex logic:

ngxingyu commented 3 years ago

Migrated to null-safety and moved test folder to the root folder. Updated changelog. I'm not sure if the backslash escape is what's intended or if there are any drawbacks to that approach, so do let me know if there's anything that can be improved.

java-james commented 3 years ago

Thanks a lot for your PR. I will take a look.

tusharsadhwani commented 3 years ago

@java-james any updates? Null safety has been in beta for quite a while now, it'll be really nice if all packages move to it

nstrelow commented 3 years ago

@java-james Please merge this at some point. THank you :D

java-james commented 3 years ago

Thanks have made time to have a look at this. Looks good. A couple of very minor changes in review. Let me know if you don't have time and I will make time to push the changes. Should be able to commit suggestions for all of them? Then good to go

java-james commented 3 years ago

@java-james Please merge this at some point. THank you :D

Agree we should get this in. Have made time to take a look. Will release after merge. Thanks

java-james commented 3 years ago

@ngxingyu Thank you for taking a look at the review. I will get this merged and released this evening.

java-james commented 3 years ago

Published to pub.dev as 4.0.0-nullsafety.0

Thanks @ngxingyu for spending the time to migrate.