java-james / loading_overlay

A simple modal progress HUD (heads-up display, or progress indicator) for flutter
https://pub.dev/packages/loading_overlay
MIT License
25 stars 12 forks source link

Doesn't work #4

Closed CripyIce closed 4 years ago

CripyIce commented 4 years ago

This library don't seem to work at all. No errors though. Flutter doctor:

[✓] Flutter (Channel beta, v1.14.6, on Mac OS X 10.15.3 19D76, locale en-IL)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[!] VS Code (version 1.42.1)
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (3 available)
java-james commented 4 years ago

Hey thanks for the issue report. Any more details on this? I'm consuming on 1.12.13+hotfix.8 without issues. Any specific error being thrown at runtime? Or you getting no overlay displayed when using it? What does the code you've implemented it in look like?

CripyIce commented 4 years ago

Hi @java-james , there are no errors. This is my code - very simple:

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key}) : super(key: key);

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Overlay Test"),
      ),
      body: LoadingOverlay(
        isLoading: true,
        child: Column(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: <Widget>[
            Text(
              'Some text',
            ),
          ],
        ),
      ),
    );
  }
}
aldwnesx commented 4 years ago

not working as well

aldwnesx commented 4 years ago

Hey thanks for the issue report. Any more details on this? I'm consuming on 1.12.13+hotfix.8 without issues. Any specific error being thrown at runtime? Or you getting no overlay displayed when using it? What does the code you've implemented it in look like?

1.12.13 doesn't exist?

java-james commented 4 years ago

Hey thanks for the issue report. Any more details on this? I'm consuming on 1.12.13+hotfix.8 without issues. Any specific error being thrown at runtime? Or you getting no overlay displayed when using it? What does the code you've implemented it in look like?

1.12.13 doesn't exist?

Ah referring to the flutter version I'm running on. Thanks I will use the info you've provided to reproduce the issue and report back here.

kashlo commented 4 years ago

same, doesnt work when LoadingOverlay is child of Scaffold

java-james commented 4 years ago

Have had a look into this. Seems like there is an issue initializing isLoading as true. (It's not picked up in the init state of the loading overlay). Can get working fine with your layout when initializing as false then changing to true via state. Will push this fix and publish this week.

Screen Shot 2020-03-22 at 10 52 47 PM
java-james commented 4 years ago

Have pushed the update as 0.2.1 Please try this version and confirm the issue is fixed James

java-james commented 4 years ago

Closing this issue. Fixed in 0.2.1 let me know if you have any other issues