java-json-tools / jackson-coreutils

JSON Pointer (RFC 6901) and numeric JSON equivalence for Jackson (2.2.x)
Other
5 stars 6 forks source link

JsonNumEquals invokes @ForOverride methods directly #23

Closed Capstan closed 5 years ago

Capstan commented 5 years ago

See https://github.com/google/error-prone/blob/master/annotations/src/main/java/com/google/errorprone/annotations/ForOverride.java

Equivalence's doHash and doEquivalent are annotated with @ForOverride and are only supposed to be implemented, not called directly. This should call hash and equivalent instead.