java-json-tools / json-schema-validator

A JSON Schema validation implementation in pure Java, which aims for correctness and performance, in that order
http://json-schema-validator.herokuapp.com/
Other
1.63k stars 399 forks source link

Fix new errorprone warnings across java-json-tools #350

Open Capstan opened 4 years ago

Capstan commented 4 years ago

Spurred by #347 .

Since Google's monorepo has warnings-as-errors turned on, I did the same for the java-json-tools repos so that new errors requiring internal patching would be caught upstream before commit. However, the new https://github.com/dependabot suggestion of pulling in 2.4.0 finds new errorprone issues, which causes the builds to fail.

This is a FR to locally pull in 2.4.0, and commit fixes to the issues so the new error prone is clean.

/cc @huggsboson