java-native / jssc

Java library for talking to serial ports (with added build support for maven, cmake, MSVC)
https://discord.gg/RBsUfE9sX9
GNU Lesser General Public License v3.0
171 stars 53 forks source link

Cross-compile pipeline: Do not overwrite cmake in dockcross containers with version from apt #145

Closed pietrygamat closed 1 year ago

pietrygamat commented 1 year ago

Installing cmake with apt is not required, and in fact causes cmake to be downgraded and warning about wrong lib version to be printed

[exec] /usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)

Additionally, at least once the pipeline compiled the library, but failed to push it to git because of file lock preventing rebase. If this happens, the command should fail and retry (even if forever) rather than quietly complete.

tresf commented 1 year ago

No objections here!