Closed pietrygamat closed 10 months ago
No objections.
A word on ubuntu-latest
:
ubuntu-latest
versus ubuntu-20.04
, it means that when a dependency name changes, our CI will fail. This is fine with me, because latest
prevents the action from bitrot and is arguably easier than trying to remember which LTS releases are still supported by GitHub.ubuntu-latest
may suffer regressions. This is best explained here.In regards to merging, I will ask you to do so at your leisure.
A small improvement to cross-compilation pipeline. It now generates a branch with a single commit with all precompiled binaries, instead of one commit per architecture.
E.g. https://github.com/pietrygamat/jssc/commits/single-commit-natives-precompiled-natives.