Some error handling in get serial port names

java-native / jssc

Java library for talking to serial ports (with added build support for maven, cmake, MSVC)

https://discord.gg/RBsUfE9sX9

GNU Lesser General Public License v3.0

171 stars 53 forks source link

Some error handling in get serial port names #171

Open hiddenalpha opened 3 months ago

hiddenalpha commented 3 months ago

Looks as there's some error handling missing here. Unluckily I do NOT have any windows box available right now. And I'm far from having a jssc build environment ready. So I'll try my best to write this code with nothing more than the msdn documentation and a good old text editor. Lets see how many compiler errors I'll produce.

Maybe somebody can have a look if this helps with #170?

maybe fixes: #170

Edit: Oh cool :) jssc got gh actions. Thanks for setting this up.

tresf commented 3 months ago

LGTM, but I haven't tested the code and it's not my area of expertise, so a second review is recommended prior to merging.