Running test with github action - Githubissues

java-operator-sdk / samples

Sample Operators using the Java Operator SDK

7 stars 12 forks source link

Running test with github action #8

Closed kanedafromparis closed 3 years ago

kanedafromparis commented 3 years ago

Hi,

This is a proposal for improvement.

unfortunalty it might be too fat because it has :

the ClusterRole correction (https://github.com/java-operator-sdk/samples/issues/7 - https://github.com/kanedafromparis/samples/blob/d49b13e68a43fccb86020659d6aed50487a247c2/tomcat/k8s/operator.yaml#L61)
the correction on war deployment time (https://github.com/kanedafromparis/samples/blob/d49b13e68a43fccb86020659d6aed50487a247c2/tomcat/src/test/java/io/javaoperatorsdk/operator/sample/IntegrationTest.java#L89)
some improvement proposal off webapp Controller
- https://github.com/kanedafromparis/samples/blob/d49b13e68a43fccb86020659d6aed50487a247c2/tomcat/k8s/crd.yaml#L29
- https://github.com/kanedafromparis/samples/blob/d49b13e68a43fccb86020659d6aed50487a247c2/tomcat/src/main/java/io/javaoperatorsdk/operator/sample/WebappController.java#L63