search

java / devjava-content

57 stars 17 forks source link

Enums #45

Closed danthe1st closed 1 year ago

danthe1st commented 1 year ago

Request issue

40

I cannot self-assign to this issue since I don't have the necessary permissions.

Website section

Getting to Know the Language>Classes and Objects>Enums

Details

This PR adds an article on the topic of enums in Java. It covers the following questions:

Since the Classes and Objects section is not present in this repository, it might be necessary to change the directory name, id or similar. For that reason, I have named the file 01_enums.md for now. Should I change that to 09_enums.md? Also, I am not sure on whether the id in the link for switch expressions is correct since that article seems to be missing from this repository as well.

wkorando commented 1 year ago

Thank you for the contribution Dan! I made some comments on areas for improvement.

danthe1st commented 1 year ago

Can someone please check whether the file/directory names, slug/id and similar as well as the link to Switch Expressions are correct? I had to guess these since these articles/the Classes and objects section are missing in this repository.

danthe1st commented 1 year ago

And I can also squash the changes to a single commit if wanted.

wkorando commented 1 year ago

And I can also squash the changes to a single commit if wanted.

Yea if you can do that at the end. That makes reviewing this addition later easier.

danthe1st commented 1 year ago

I have now made a few changes to the conclusion section in order to (hopefully) address @ammbra's feedback and make it easier to understand. I am thinking about removing the last paragraph altogether as it might be a bit confusing and ambiguous as already mentioned.

carimura commented 1 year ago

Moving to PR #47 since I worked in a different branch. Sorry! Once comments are resolved here, we can update #47 and merge.

danthe1st commented 1 year ago

I just want to mention that with this approach, I will not be able to squash it or do any changes in that branch so one of you would need to do this if needed.

carimura commented 1 year ago

no problem you can work in your branch and I can update. I've changed the conclusion a bit, see if you like it.

carimura commented 1 year ago

Can you merge the changes from https://github.com/java/devjava-content/compare/main...danthe1st-enums into your branch so this PR is the active one?

danthe1st commented 1 year ago

I have merged it as well as changed another to a in the conclusion (They are a special type of class) since the article series doesn't mention other types of classes.

carimura commented 1 year ago

Thank you @danthe1st for your contribution and congrats on being the first approved community contribution! Once merged here we'll port it to the live site soon. Shoot me an email or Twitter DM and we'll arrange for a small thank you to be sent your way.

(thanks @wkorando and @ammbra for your reviews)

carimura commented 1 year ago

in case you missed it https://dev.java/learn/classes-objects/enums/