search

java / devjava-content

55 stars 16 forks source link

debugging article ready for review #57

Closed boyarsky closed 10 months ago

boyarsky commented 10 months ago

This is the article for request #43

boyarsky commented 10 months ago

Replied to all the easy comments :). The ones I didn't reply to are because I didn't have enough time before my 7pm call, not because I disagree. I'll look at those later tonight or tomorrow.

boyarsky commented 10 months ago

I think I replied to everything now

carimura commented 10 months ago

hey @danthe1st @wkorando appears there are two "conversations" that need resolved and it appears ya'll might be on point with them. If you resolve I can get this merged and deployed!

danthe1st commented 10 months ago

I don't have the permissions to mark conversations as resolved (also not on my own review comments).

However,it seems like all of my comments (unless maybe the links which seems to be fine) have been addressed.

boyarsky commented 10 months ago

All resolved. One was open because I made an edit in response to Dan's comment last night so I wanted to give him 24 hours to read what I wrote. (Thanks for the confirmation Dan.) The other I had already addressed but miss the resolve button.

carimura commented 10 months ago

Excellent thank you @boyarsky for the great article and @danthe1st @wkorando for the review! I'll get this deployed soon!

carimura commented 10 months ago

This has been merged to prod and deployed. Thanks again!