search

java / devjava-content

55 stars 16 forks source link

Add tutorial "Building a Java application in IntelliJ IDEA" (fixes #62) #70

Closed mlvandijk closed 5 months ago

mlvandijk commented 6 months ago

Add tutorial for "Building a Java application in IntelliJ IDEA", based on the outline as discussed in #62 with the following additions/changes:

Please let me know what you think / if any changes are needed. Thanks!

oracle-contributor-agreement[bot] commented 6 months ago

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

danthe1st commented 6 months ago

Also I think you haven't added your name as an author. I don't think this is mandatory but I wanted to make sure you know about it being possible.

mlvandijk commented 6 months ago

@danthe1st Thanks for taking the time to review, I really appreciate it! Please note that I took an existing article on coding with an IDE and used that as an example for the description and the content. An outline of the content was discussed in the proposal (#62). I'll address a few of your comments separately, but ultimately wait for review from Oracle DevRel team on what to change. For example, I did notice the option to add my name as an author, but tbh I care more about adding the content then I do about having my name on there. Happy to add it if required.

mlvandijk commented 6 months ago

@danthe1st @ammbra Pushed changes that resolve most but not yet all of the comments. Remaining few I'll think about and make more changes later.

mlvandijk commented 6 months ago

Also, OCA is in progress.

mlvandijk commented 6 months ago

@ammbra As discussed: Add myself as author

mlvandijk commented 5 months ago

Hi @ammbra - pushed changes that should resolve all remaining comments in line with what we discussed last week. OCA stil in progress on our end.

danthe1st commented 5 months ago

I don't really see https://github.com/java/devjava-content/pull/70#discussion_r1521987186 being addressed. Also I don't see anything coming out of https://github.com/java/devjava-content/pull/70#discussion_r1523734884 (most of the Evolving the project is pointless for beginners in my opinion and I don't see any summary). I still don't agree with it being necessary to make Maven a fundamental part of this tutorial just for the sake of being able to introduce testing but if it is that way, it's fine. One other thing I noticed is that you wrote macOS a few times with a lowercase m. Is it actually called macOS instead of MacOS? Aside from that, it might be a good idea to group all IDE articles together similar to how the Classes and Objects section is grouped (to not occlude the /learn page too much) but I will await Ana's decision on that.

ammbra commented 5 months ago

I don't really see #70 (comment) being addressed. Also I don't see anything coming out of #70 (comment) (most of the Evolving the project is pointless for beginners in my opinion and I don't see any summary). I still don't agree with it being necessary to make Maven a fundamental part of this tutorial just for the sake of being able to introduce testing but if it is that way, it's fine. One other thing I noticed is that you wrote macOS a few times with a lowercase m. Is it actually called macOS instead of MacOS? Aside from that, it might be a good idea to group all IDE articles together similar to how the Classes and Objects section is grouped (to not occlude the /learn page too much) but I will await Ana's decision on that.

I will wait for @mlvandijk to push some more changes and once this is done, will look into fitting this article in they are own section/series.

mlvandijk commented 5 months ago

@ammbra - Just pushed the changes as discussed today. @danthe1st - Nice catch on JUnit 5 -> fixed this as well. And yes, it is macOS (see the apple website).

mlvandijk commented 5 months ago

@ammbra @danthe1st - do either of you want to raise issues for some topics that were mentions as "should have it's own section" during the review? Off the top of my head, this was mentioned for: version control/git, build systems (Maven/Gradle), testing. Once those are available we can link to them from this article / other relevant places.

danthe1st commented 5 months ago

I am unsure on whether these should actually be articles as these things are not really a part of Java (especially version control/git).

oracle-contributor-agreement[bot] commented 5 months ago

Thank you for signing the OCA.