search

javaBin / javazone-ios-app

MIT License
2 stars 0 forks source link

Crash on svg processing #37

Closed chrissearle closed 2 years ago

chrissearle commented 2 years ago

When we download SVG partner logos we need to convert them to png to use in SwiftUI Image.

We use SVGKit for that.

In this method - SVGKit gets an unexpected nil - which is handled with an NSLog - and then this returns nil.

https://github.com/SVGKit/SVGKit/blob/3.x/Source/Sources/SVGKSourceURL.m#L23-L49

The calling method (also in SVGKit) asserts not nil - which crashes the app.

I suspect that for the production version we send out for 2021 I will download the list and add them as an asset catalog instead.

chrissearle commented 2 years ago

Removed SVGKit and download of images entirely