search

javacc / javaccPlugin

A JavaCC plugin for Gradle
MIT License
33 stars 16 forks source link

Use Matcher.quoteReplacement to make acceptanceTest successful. #37

Closed zosrothko closed 7 years ago

zosrothko commented 7 years ago

Otherwise, one gets

javacc.compilation.ThePluginCompilesJavaccToExpectedDirectoryStory > givenASimpleProjectWithCustomAstClassesWhenRerunCompileJavaccTaskThenTheFilesThatDoNotHaveACorrespondingCustomAstClassAreGeneratedInTheDefaultDirectory FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at ThePluginCompilesJavaccToExpectedDirectoryStory.java:341

javacc.compilation.ThePluginCompilesJavaccToExpectedDirectoryStory > givenASimpleProjectWithCustomAstClassesWhenExecuteCompileJavaccTaskThenTheFilesThatDoNotHaveACorrespondingCustomAstClassAreGeneratedInTheDefaultDirectory FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at ThePluginCompilesJavaccToExpectedDirectoryStory.java:309

27 tests completed, 2 failed
:javacc-gradle-plugin:acceptanceTest FAILED
codecov-io commented 7 years ago

Current coverage is 95.79% (diff: 100%)

Merging #37 into master will not change coverage

@@             master        #37   diff @@
==========================================
  Files            14         14          
  Lines           357        357          
  Methods           0          0          
  Messages          0          0          
  Branches         39         39          
==========================================
  Hits            342        342          
  Misses            8          8          
  Partials          7          7

Powered by Codecov. Last update c4cc8ec...81f06d0

johnmartel commented 7 years ago

Sorry, I went on an unplanned vacation, and I'm catching up now that I am back. I will be happy to merge this, as it works, but the build is passing as well without it see the travis builds, so I'm reluctant to merge before I can understand why you needed this fix.

Can you provide me with more details on the failures you get without this fix, i.e. JDK used, what kind of system, etc. ?

zosrothko commented 7 years ago

Joined are the reports files as classess.zip. I think this issue appears beacause the acceptanceTests are running on Windows. AcceptanceTest on Travis are running on Linux, so the path separator is different as on Windows. May be you can push JavaCCPlugin acceptance testing on AppVeyor?

Z:\git\javaccPlugin>java -version
java version "1.8.0_122-ea"
Java(TM) SE Runtime Environment (build 1.8.0_122-ea-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.122-b01, mixed mode)

Running system: Win7 Pro, amd64

classes.zip

johnmartel commented 7 years ago

Merged. Thanks for pointing this out!